Allow generating commatrix from csv and fix samples #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirmoran
force-pushed
the
fix-generate-commatrix-from-file
branch
from
2ff39b1
to
37bd46c
Compare
aabughosh
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node role header of a commatrix in the csv format, defers from those of types json and yaml (
Node Roleinstead ofnodeRole). So, csv annotations inComDetailsstruct were added.The previous custom entries examples had some incorrect parameters which were fixed:
NodeRolecolumn was changed toNode Rule(as in the documented commatrix.a unit test applying the custom entries samples will be added in a separate PR.